CHANGELOG.md

@@ -2,20 +2,6 @@
 
 All notable changes to this project will be documented in this file.
 
-## Version 0.8.0 - 2024-12-02
-
-### Bug Fixes
-
-- Clear generator when source is cleared, and improve handling for changing source types.
-
-### Features
-
-- Add `Sound.playback_position` to support initializing new buffers at non-zero playback position.
-
-### Miscellaneous Tasks
-
-- Clean up code.
-
 ## Version 0.7.0 - 2024-07-07
 
 ### Miscellaneous Tasks

src/lib.rs

@@ -156,7 +156,6 @@ pub struct Sound {
     pub gain: f64,
     pub pitch: f64,
     pub looping: bool,
-    pub playback_position: f64,
     pub paused: bool,
     pub generator: Option<syz::Generator>,
 }
@@ -168,7 +167,6 @@ impl Default for Sound {
             gain: 1.,
             pitch: 1.,
             looping: false,
-            playback_position: default(),
             paused: false,
             generator: None,
         }
@@ -231,9 +229,7 @@ fn add_source_handle(
     )>,
 ) {
     for (mut source, panner_strategy, transform, angular_pan, scalar_pan) in &mut query {
-        if source.handle.is_some() {
+        if source.handle.is_none() {
-            continue;
-        }
             let panner_strategy = panner_strategy.cloned().unwrap_or_default();
             let handle: syz::Source = if let Some(transform) = transform {
                 let translation = transform.translation();
@@ -269,6 +265,7 @@ fn add_source_handle(
             source.handle = Some(handle);
         }
     }
+}
 
 fn add_generator(
     context: Res<Context>,
@@ -278,9 +275,7 @@ fn add_generator(
     parents: Query<&Parent>,
 ) {
     for (entity, parent, mut sound) in &mut query {
-        if sound.generator.is_some() {
+        if sound.generator.is_none() {
-            continue;
-        }
             let mut source = if let Ok(s) = sources.get_mut(entity) {
                 Some(s)
             } else if parent.is_some() {
@@ -305,11 +300,6 @@ fn add_generator(
                                 let generator = syz::BufferGenerator::new(&context)
                                     .expect("Failed to create generator");
                                 generator.buffer().set(&**b).expect("Unable to set buffer");
-                            assert!(sound.playback_position >= 0.);
-                            generator
-                                .playback_position()
-                                .set(sound.playback_position)
-                                .expect("Failed to set playback position");
                                 Some(generator.into())
                             } else {
                                 None
@@ -317,9 +307,7 @@ fn add_generator(
                         }
                         Audio::Generator(generator) => Some(generator.clone()),
                     };
-                let Some(generator) = generator else {
+                    if let Some(generator) = generator {
-                    continue;
-                };
                         assert!(sound.gain >= 0.);
                         generator
                             .gain()
@@ -338,6 +326,8 @@ fn add_generator(
                 }
             }
         }
+    }
+}
 
 fn add_sound_without_source(
     mut commands: Commands,
@@ -371,7 +361,6 @@ fn swap_buffers(
         if let Some(l) = last_audio.get(&entity) {
             if sound.generator.is_some() && sound.audio != *l {
                 sound.generator = None;
-                sound.playback_position = 0.;
             }
         }
         last_audio.insert(entity, sound.audio.clone());
@@ -393,14 +382,13 @@ fn change_panner_strategy(
         check.push(entity);
     }
     for entity in check.iter() {
-        let Ok(mut source) = sources.get_mut(*entity) else {
+        if let Ok(mut source) = sources.get_mut(*entity) {
-            continue;
-        };
             if source.handle.is_some() {
                 source.handle = None;
             }
         }
     }
+}
 
 fn update_source_properties(
     context: Res<Context>,
@@ -415,7 +403,6 @@ fn update_source_properties(
         Option<&AngularPan>,
         Option<&ScalarPan>,
         Option<&GlobalTransform>,
-        Option<&mut Sound>,
     )>,
 ) {
     for (
@@ -429,18 +416,15 @@ fn update_source_properties(
         angular_pan,
         scalar_pan,
         transform,
-        sound,
     ) in &mut query
     {
         let Source { gain, .. } = *source;
         assert!(gain >= 0.);
-        let Some(handle) = source.handle.as_mut() else {
+        if let Some(handle) = source.handle.as_mut() {
-            continue;
-        };
             handle.gain().set(gain).expect("Failed to set gain");
             let mut clear_source = false;
-        if let Some(source) = handle.cast_to::<syz::Source3D>().expect("Failed to cast") {
             if let Some(transform) = transform {
+                if let Some(source) = handle.cast_to::<syz::Source3D>().expect("Failed to cast") {
                     let translation = transform.translation();
                     source
                         .position()
@@ -478,7 +462,6 @@ fn update_source_properties(
                         .map(|v| **v)
                         .unwrap_or_else(|| context.default_rolloff().get().unwrap());
                     assert!(rolloff >= 0.);
-                assert!(rolloff >= 0.);
                     source
                         .rolloff()
                         .set(rolloff)
@@ -491,9 +474,10 @@ fn update_source_properties(
                         .closeness_boost()
                         .set(closeness_boost)
                         .expect("Failed to set closeness_boost");
-                let closeness_boost_distance = closeness_boost_distance
+                    let closeness_boost_distance =
-                    .map(|v| **v)
+                        closeness_boost_distance.map(|v| **v).unwrap_or_else(|| {
-                    .unwrap_or_else(|| context.default_closeness_boost_distance().get().unwrap());
+                            context.default_closeness_boost_distance().get().unwrap()
+                        });
                     assert!(closeness_boost_distance >= 0.);
                     source
                         .closeness_boost_distance()
@@ -502,11 +486,11 @@ fn update_source_properties(
                 } else {
                     clear_source = true;
                 }
-        } else if let Some(source) = handle
+            } else if let Some(angular_pan) = angular_pan {
+                if let Some(source) = handle
                     .cast_to::<syz::AngularPannedSource>()
                     .expect("Failed to cast")
                 {
-            if let Some(angular_pan) = angular_pan {
                     assert!(angular_pan.azimuth >= 0. && angular_pan.azimuth <= 360.);
                     source
                         .azimuth()
@@ -520,11 +504,11 @@ fn update_source_properties(
                 } else {
                     clear_source = true;
                 }
-        } else if let Some(source) = handle
+            } else if let Some(scalar_pan) = scalar_pan {
+                if let Some(source) = handle
                     .cast_to::<syz::ScalarPannedSource>()
                     .expect("Failed to cast")
                 {
-            if let Some(scalar_pan) = scalar_pan {
                     assert!(**scalar_pan >= -1. && **scalar_pan <= 1.);
                     source
                         .panning_scalar()
@@ -533,22 +517,9 @@ fn update_source_properties(
                 } else {
                     clear_source = true;
                 }
-        } else if handle
-            .cast_to::<syz::DirectSource>()
-            .expect("Failed to cast")
-            .is_some()
-        {
-            if transform.is_some() || angular_pan.is_some() || scalar_pan.is_some() {
-                clear_source = true;
-            }
-        } else if source.handle.is_some() {
-            clear_source = true;
             }
             if clear_source {
                 source.handle = None;
-            if let Some(mut sound) = sound {
-                sound.generator = None;
-                sound.playback_position = 0.;
             }
         }
     }
@@ -564,21 +535,7 @@ fn update_sound_properties(mut query: Query<&mut Sound>) {
         } = *sound;
         assert!(gain >= 0.);
         assert!(pitch > 0. && pitch <= 2.);
-        let Some(generator) = &sound.generator else {
+        if let Some(generator) = sound.generator.as_mut() {
-            continue;
-        };
-        if let Some(generator) = generator
-            .cast_to::<syz::BufferGenerator>()
-            .expect("Failed to cast")
-        {
-            sound.playback_position = generator
-                .playback_position()
-                .get()
-                .expect("Failed to getplayback position");
-        }
-        let Some(generator) = sound.generator.as_mut() else {
-            continue;
-        };
             generator.gain().set(gain).expect("Failed to set gain");
             generator
                 .pitch_bend()
@@ -595,12 +552,11 @@ fn update_sound_properties(mut query: Query<&mut Sound>) {
             }
         }
     }
+}
 
 fn update_source_playback_state(query: Query<&Source>) {
     for source in &query {
-        let Some(handle) = &source.handle else {
+        if let Some(handle) = &source.handle {
-            continue;
-        };
             if source.paused {
                 handle.pause().expect("Failed to pause");
             } else {
@@ -608,12 +564,11 @@ fn update_source_playback_state(query: Query<&Source>) {
             }
         }
     }
+}
 
 fn update_sound_playback_state(query: Query<&Sound>) {
     for sound in &query {
-        let Some(generator) = &sound.generator else {
+        if let Some(generator) = &sound.generator {
-            continue;
-        };
             if sound.paused {
                 generator.pause().expect("Failed to pause");
             } else {
@@ -621,6 +576,7 @@ fn update_sound_playback_state(query: Query<&Sound>) {
             }
         }
     }
+}
 
 fn remove_sound(mut last_buffer: ResMut<LastAudio>, mut removed: RemovedComponents<Sound>) {
     for entity in removed.read() {
@@ -698,13 +654,9 @@ fn events(
     mut output: EventWriter<SynthizerEvent>,
 ) {
     context.get_events().for_each(|event| {
-        let Ok(event) = event else {
+        if let Ok(event) = event {
-            return;
-        };
             for (entity, sound) in &sounds {
-            let Some(generator) = &sound.generator else {
+                if let Some(generator) = &sound.generator {
-                continue;
-            };
                     if *generator.handle() == event.source {
                         match event.r#type {
                             syz::EventType::Finished => {
@@ -718,6 +670,8 @@ fn events(
                         break;
                     }
                 }
+            }
+        }
     });
 }